PathOfBuilding icon indicating copy to clipboard operation
PathOfBuilding copied to clipboard

Trade search weapon type selection

Open mcmanustfj opened this issue 1 year ago • 1 comments

Fixes #6832.

Description of the problem being solved: Can't change weapon class in trade search.

Especially useful if I have two 1h weapons and want to swap the second one to a shield (or vice versa)

Steps taken to verify a working solution:

  • Create build
  • Add weapon to weapon 2
  • Trade for these items
  • Find best
  • See new "Item Type" dropdown

After screenshot:

image

image

Notes:

  • Currently not doing all base classes, just the important ones
  • Only have possible offhand weapons/shields/quivers for weapon 2, but don't do any validation (i.e. will not stop you from getting a shield and a bow.

mcmanustfj avatar Apr 04 '24 18:04 mcmanustfj

if any other features start modifying the item class for trade lookup, I would suggest creating a lookup table with all the item types and query strings

mcmanustfj avatar Apr 04 '24 18:04 mcmanustfj