Frostblink is not included in FullDPS

[test544]

Check version

• [X] I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

• [X] I've checked for duplicate open and closed issues by using the search function of the issue tracker

How is Path of Building expected to behave?

Any skill marked as "include in fullDPS" to be shown in FullDPS section, but default frostblink gem is not

How does Path of Building behave?

Pob doesn't show FullDPS section; nor include Frostblink if the section is enabled from other skill

How to reproduce the issue

• create a fresh build;
• add default frostblink gem;
• toggle include in fullDPS;
• see no FullDPS section appearing

Character build code

https://pobb.in/ktiaLSvc5pwV

Screenshots

note: I understand that skill dps is quite unstable, but even basic approximation AverageHit * TooltipCooldown would be nice to have, as i can tune cooldown as i need via custom modifiers

[sida-wang]

Dev notes from my debugging session yesterday in case someone is working on this before I can finish it tonight.

Most of the DPS calculations in CalcOffence.lua use something along the lines of Damage * Speed * Other multis The speed term used is (globalOutput.HitSpeed or globalOutput.Speed).

In the case of Frostblink, because this is an instant skill, output.Speed = 0 in L1982 and the else section that sets the speed if there is a cooldown L2121 doesn't get run (would need to be modified anyway). globalOutput takes the values from output for future passes.

This is affects output.TotalDPS in L3235 which results in the DPS being 0. Note that appropriate change would be to fix the output.Speed term so that other instances of the speed term is handled appropriately e.g. it's also used for poison calcs.