CoC 'Eff. Source Rate' results in inaccuracies when crit chance < 100% and APS > Trigger Rate Cap

[pnmueller]

Check version

• [X] I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

• [X] I've checked for duplicate issues by using the search function of the issue tracker

Check for support

• [X] I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).

What is the value from the calculation in-game?

If you are above a trigger rate cap, e.g., 8.10 APS with a cap of 7.58, reducing your hit or crit chance can never increase the trigger rate because crits still occur within the spell cooldown, just some are converted into misses/hits.

What is the value from the calculation in Path of Building?

In the same scenario, PoB currently calculates the average number of crits / second as "Eff. Source Rate" and reducing your hit or crit chance shows a higher DPS in PoB because that value can be brought closer to the trigger rate cap.

How to reproduce the issue

This can be reproduced by either checking the PoB from the Reddit thread linked below and removing rings to reduce accuracy or creating a simpler test scenario such as:

1. Create an empty build
2. Add a 3-link 20/0 setup consisting of Cyclone, Cast on Critical Strike, and Frostbolt
3. In the Custom Modifiers, add "Your hits can't be evaded", "60% increased cooldown recovery rate", "200% increased attack speed", and "+100% to critical strike chance"
4. Frostbolt now shows with a trigger rate of 8.7 because your APS (10.8) is above the trigger rate cap (10.1) - this is correct
5. Change the "+100% to critical strike chance" in the Custom Modifiers to "+90% to critical strike chance"
6. Frostbolt now shows with a trigger rate of 9.72 because the "Eff. Source Rate" in the Calcs averages crits - this is incorrect because you still have the same delay between crits (= including the same amount of crits that fall within the spell cooldown because your APS it too high), just that 10% of them are randomly converted to hits and cannot trigger CoC at all

In practice, the trigger rate would be somewhere between 8.7 * 0.9 = 7.83 and 8.7, and not 9.72.

Character build code

https://pobb.in/BApyW_-3aRG0
(taken from https://www.reddit.com/r/PathOfExileBuilds/comments/193rg33/hey_guys_need_help_understanding_why_when_i_apply/)

Screenshots

No response