PathOfBuilding icon indicating copy to clipboard operation
PathOfBuilding copied to clipboard

Incorrect non-damaging ailment calculation with minimum shock

Open auspex92 opened this issue 2 years ago • 6 comments

Check version

  • [X] I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

  • [X] I've checked for duplicate issues by using the search function of the issue tracker

Check for support

  • [X] I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).

What is the value from the calculation in-game?

With "Shocks from your Hits always increase Damage taken by at least 10%" mod, Level 5 Awakened Unbound Ailments and 7 Affliction Charges, I should get at least 26% shock on everything as long as I'm dealing crits with at least 1 lightning damage.

I haven't tested this in game, but this is the general consensus as to how Shaper of Storms and Shaper of Winter work, as per Mark's response on https://www.reddit.com/r/pathofexile/comments/81b41p/comment/dv3emop/?utm_source=share&utm_medium=web2x&context=3 regarding now removed Beacon of Ruin ascendancy, which was a combination of Shaper of Storms and Shaper of Winter.

What is the value from the calculation in Path of Building?

In Path of Building, the current shock modifier reads 15% with the setup above, even though the shock effect mod reads x2.64, which is correct. I have no clue how Path of Building obtains the 15% value.

The issue is not related to Affliction Charges, because the calculation is still incorrect without Affliction Charges. With Shocks from your Hits always increase Damage taken by at least 10% and Level 5 Awakened Unbound Ailments, the shock seems to be 10% although the shock effect mod reads x1.69.

How to reproduce the issue

Select any skill and support it with normal or awakened Unbound Ailments

Add custom config for "Shocks from your Hits always increase Damage taken by at least 10%" (this mod is supported and works, because changing the number changes dps) or allocate something like Shaper of Storms/Scion Elementalist

Check Non-Damaging Ailments in the calcs tab

Character build code

https://pobb.in/KEHutQQ6uQev

Screenshots

image

auspex92 avatar Jan 09 '24 03:01 auspex92

Dev Notes: Seems like it's only caring about Affliction Charges as that's 56% more effect and the Current Shock's value is 15.6 or 10% x 1.56.

I don't know if the unbound ailments increased shock effect should be applying to that mod as well. Probably?

Peechey avatar Jan 09 '24 05:01 Peechey

It should definitely be applying to that mod, that's how it obtains the x2.64 value, because 1.69*1.56 is 2.636.

auspex92 avatar Jan 09 '24 07:01 auspex92