PathOfBuilding icon indicating copy to clipboard operation
PathOfBuilding copied to clipboard

ux: Increase the size of the "Custom Modifiers" control

Open ryuukk opened this issue 2 years ago • 3 comments

Fixes section 2 of #6044

Description of the problem being solved:

Custom modifiers is too small, specially when the builds has to put spectre/ag data of if it has notes, it becomes unmanageable

Steps taken to verify a working solution:

  • open blank build
  • open build with lot of custom modifiers

Link to a build that showcases this PR:

https://pobb.in/e9vCTwRA_eoA

Before screenshot:

image

After screenshot:

image

Clear improvement

ryuukk avatar Dec 30 '23 15:12 ryuukk

I went with this easiest method, i initially tried to add a mode so it dynamically increases its height, but i failed, i'll try again later

ryuukk avatar Dec 30 '23 15:12 ryuukk

Ok looks like it's working now

It'll properly resize to show the content

https://github.com/PathOfBuildingCommunity/PathOfBuilding/assets/44361234/367a8514-0777-4467-b994-def5d824e58e

ryuukk avatar Dec 30 '23 16:12 ryuukk

  • If the box is going to dynamically increase its height, there's no need for the vertical scrollbar.

I agree, i'll check how to disable them

  • There should probably be some upper limit to how tall the box is, perhaps make it a config (this can be done later)

I agree, i'll what can be done

  • When opening an old build with a large amount of custom mods, it doesn't update the size until you click on the box

I'll try to fix that

  • The most jarring thing though is that every time you hit enter to add a new line all the text jolts up one line then back when the box adjusts to make space

Yeah, that's how the UI framework handles resizing that control, i haven't, and i'm not willing to debug this, unless i have more time

ryuukk avatar Jan 01 '24 09:01 ryuukk