PathOfBuildingCommunity
Adding trade link generator to items tab for selected item
This is working, currently it is hitting 2 POE API's
Creating the pull request for visibility of what i've done and to get feedback as to what i need to improve, what i've missed that i could use thats already been implemented.
I'm aware of the existing QueryMods.lua file, however im unaware of a way to loop over a key/value table, so im hitting the API to get the raw data from POE.
If there is no way to loop over the key/value table i would like to cache the API call, and only hit it once a day? i've implemented this but i get a memory error when trying to write the whole response to file. so would need some help moving forward for this direction.
- unfinished - need to add error handling
- need to get items numeric values to add to min's when generating the attributes
- i have not set up searching for implicit mods - would this even be wanted/needed?
- i'm removing the special mod tags (fractured, crafted, ect...) and pulling the id's for the regular mod - this way it searches for items with any type of the mod.
Fixes # .
Description of the problem being solved:
New feature
Steps taken to verify a working solution:
- tested several items
Link to a build that showcases this PR:
Before screenshot:
After screenshot:
Resolved all issues from above. have checked with some uniq items now also and its work as expected. I still need to change from hitting the API to using the ModQuery.lua file to get the Mod ID's.
src/Classes/TradeQueryCurItem.lua:8:10 Unknown word (leauge)
src/Classes/TradeQueryCurItem.lua:43:11 Unknown word (attribuit)
src/Classes/TradeQueryCurItem.lua:57:22 Unknown word (attribuit)
src/Classes/TradeQueryCurItem.lua:59:85 Unknown word (attribuit)
src/Classes/TradeQueryCurItem.lua:63:67 Unknown word (attribuites)
src/Classes/TradeQueryCurItem.lua:137:32 Unknown word (attribuites)
src/Classes/TradeQueryCurItem.lua:169:46 Unknown word (attribuite)
src/Classes/TradeQueryCurItem.lua:179:29 Unknown word (attribuite)
src/Classes/TradeQueryCurItem.lua:195:27 Unknown word (recieve)
src/Classes/TradeQueryCurItem.lua:199:74 Unknown word (leauge)
src/Classes/TradeQueryCurItem.lua:217:63 Unknown word (leauge)
Your PR still has spelling errors:
src/Classes/TradeQueryCurItem.lua:8:10 Unknown word (leauge)
src/Classes/TradeQueryCurItem.lua:63:67 Unknown word (attributees)
src/Classes/TradeQueryCurItem.lua:130:46 Unknown word (attributee)
src/Classes/TradeQueryCurItem.lua:140:29 Unknown word (attributee)
src/Classes/TradeQueryCurItem.lua:160:74 Unknown word (leauge)
src/Classes/TradeQueryCurItem.lua:178:63 Unknown word (leauge)
src/Classes/TradeQueryCurItem.lua:182:32 Unknown word (attributees)
src/Data/RawQueryMods.lua:4:13 Unknown word (leauge)
("league" and "attributes" are the correct spellings.)
not sure how i missed the "leauge", the "attributees" were due to a search and replace, they are fixed now.
Hi @Tmcrocker89 are you be able to continue with this ? I would like to help and improved few things here
Hi @Tmcrocker89 are you be able to continue with this ? I would like to help and improved few things here
Yes i plan to, they are wanting me to rework the QueryMods.lua to include all item affix's and still flag the current ones for the current find best item feature.
To do that i need to learn how to export the data from the Content.ggpk
i attempted this but was unsuccessful and have gotten really busy with work so haven't had time to do more with it.
i have been using it this league and found a few more bugs that also need to be fixed. (mostly item mods local vs non local), but if you want to contribute im all for it, getting the QueryMods.lua done is whats holding it up from being merged into the main app.
I can help with that, if you are in the POB discord we can talk there, i know somethings and I have some ideas how to succes with that goal, but i dont want to duplicate effort / code