General's Cry Incorrect Behavior with Blade Flurry

[Pro7ech]

Check version

• [X] I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

• [X] I've checked for duplicate issues by using the search function of the issue tracker

Check for support

• [X] I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).

What is the behaviour in-game?

Mirage Warriors will either:

• Channel for up to 0.6sec -> release -> disappear (0.6sec channel time cap)
• Channel up to 6 stacks -> release -> disappear (1 attack cap)

What is the behaviour in Path of Building?

It seems that Path of Building ignores the 0.6sec channel time cap and 1 max attack cap for Blade Flurry, instead it multiplies the average damage by the attack rate. This leads to a highly inflated DPS.

I suggest the following solution:

• Cap the maximum number of stages providing a bonus to effective_max_stages = min(floor(attack_rate * general_cry_max_channel_time), base_max_stages).
• Multiply the DPS by effective_max_stages/attack_rate to normalize it over 1 second, i.e. get the total damage done per 0.6sec of channeling, similar to non-channeled skills.

This way we can get a much more accurate read on the expected damage, without removing/modifying the tooltip about the attack rate, which is important for gearing, and the only remaining step to get the actual DPS is isolated to managing the warcry cooldown and spawning rate of the warriors.

How to reproduce the issue

1. Add General's Cry, Blade Flury and equip a valid weapon
2. Go to Calcs, select and highlight Skill DPS

Character build code

https://pastebin.com/L449UAZX

Screenshots

[gigipig]

Very nice work. I hope they implement a solution for this.