PathOfBuilding icon indicating copy to clipboard operation
PathOfBuilding copied to clipboard

Critical cull chance uses hit rate

Open andrewbelu opened this issue 3 years ago • 0 comments

Description of the problem being solved:

Critical cull chance was using just critical strike chance before. This should be based on hit rate because we are measuring DPS rather than a single hit.

Steps taken to verify a working solution:

Ensure that culling critical strikes take hit rate into account

  • Ensured DPS increases on Assassin's Ambush and Assassinate and Marylene's Fallacy
  • Ensured max cull is used appropriately with critical culling strike (with Culling Strike gem and Slayer's Headsman)

Link to a build that showcases this PR:

https://pastebin.com/C97LKLP7

Before screenshot:

image

After screenshot:

image

andrewbelu avatar Dec 16 '22 17:12 andrewbelu