PathOfBuildingCommunity
Trade finder has different weights for the same stat
Check version
- [X] I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- [X] I've checked for duplicate issues by using the search function of the issue tracker
Check for support
- [X] I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the behaviour ingame?
For my build attack speed, attack speed while holding a shield and attack speed with wand attacks all give the same dps increase since i am wearing a wand and shield and only doing wand attacks.
What is the behaviour in Path of Building?
The trade item finder assigns different weights to all these stats when they should have the same weight. A slightly different weighting would not be a problem but a 10% difference seems pretty large.
How to reproduce the issue
- Make int stacking wander build e.g. https://pastebin.com/5A6QZDYy
- Click on "Trade for these items" in "Items" tab
- Click on "Find best" for a jewel socket ( i clicked on jewel socket # 15)
- Copy the link into browser and look at the weights
Character build code
https://pastebin.com/5A6QZDYy
Screenshots
No response
I suspect this is cause by how we generate the weights. I think the weights are generated by taking the mod in question at 70% of range and then calculating its dps these are then ordered and top ~35 are taken and converted to per point wait. This means some stats might experience more / less diminishing returns based upon the magnitude of their roll afaik.
QuickStick is correct, though it's 50% of the range. I believe this is the best approximation we can do when weighting stats across a range, despite looking odd in cases like this.
Ah i see. One could calculate the dps per 1 (or 10 for higher weights) of the stat again after taking only the top 35% but it doesnt seem like it would matter all that much.