PathOfBuilding icon indicating copy to clipboard operation
PathOfBuilding copied to clipboard

Fix fullDPS having signifcantly larger numbers on second pass

Open QuickStick123 opened this issue 3 years ago • 0 comments

Fixes https://github.com/PathOfBuildingCommunity/PathOfBuilding/issues/5258 https://github.com/PathOfBuildingCommunity/PathOfBuilding/issues/4982

Description of the problem being solved:

preDamageFunc and other similar gem functions were getting called twice between comparisons, it uses previous dpsMultiplier in calculations this resulted in the numbers being ^2 on the second calculation always making every node seem more powerful then it should. This fixes it so it always wiped so this assumption / reuse of stacking multipliers is fine.

Steps taken to verify a working solution:

image image

Link to a build that showcases this PR:

https://pobb.in/TfhBprEH-M3D

QuickStick123 avatar Dec 13 '22 10:12 QuickStick123