PathOfBuilding icon indicating copy to clipboard operation
PathOfBuilding copied to clipboard

Calculate explosive trap dps

Open dakraSz opened this issue 3 years ago • 6 comments

Check for duplicates

  • [X] I've checked for duplicate issues by using the search function of the issue tracker

Is your feature request related to a problem?

Pob doesn't calculate small explosions damage

Describe the solution you'd like

if i'm not wrong all small explosions can't always hit. we have to calculate as written manually

Describe alternatives you've considered

No response

Additional context

No response

dakraSz avatar Dec 12 '22 00:12 dakraSz

How do you think these calculations would go could you provide a breakdown to allow this to be easier to implement?

QuickStick123 avatar Dec 12 '22 00:12 QuickStick123

According to the wiki, nothing mentions that they do less damage. and the pob already deals 1 burst damage. we will only write the number of hits considered and the damage will be calculated

dakraSz avatar Dec 12 '22 01:12 dakraSz

@QuickStick123 Something closer to Storm Burst can be done. Storm Burst *DPS section shows two options, one orb tick, and all ticks at the end of duration. Make Explosive Trap *DPS section that there is two options, one small explosions, and all small explosions possible (not explosions that hits, every explosions that skill can deal.)

Explosive traps gem progression is already on wiki,

https://pathofexile.fandom.com/wiki/Explosive_Trap#:~:text=Explosive%20Trap%20is%20a%20spell,that's%20converted%20to%20fire%20damage.

I could help if I knew Lua, but I. hope you understood my friend and me.

caner-cetin avatar Dec 12 '22 13:12 caner-cetin

Also check out, https://github.com/PathOfBuildingCommunity/PathOfBuilding/issues/811#issue-603254169

To summarize, show two kind of dps, one is per explosion/wave, one is all explosions/waves

caner-cetin avatar Dec 12 '22 14:12 caner-cetin

You should be able to implement it similarly to seismic trap dps calculations the dps mulitplier would be (1 + hitChanceOfSmallExplosion * SmallExplosions). The code for calculation this kind of hitChance is already in the seismic trap preDamageCalc in act_dex.lua If you want to have a go at bit of easy programming. :)

QuickStick123 avatar Dec 12 '22 14:12 QuickStick123

This is very large scale project, and I have zero intentions to learn Lua from the ground, I will leave this to future contributors :)

caner-cetin avatar Dec 12 '22 14:12 caner-cetin