PathOfBuilding icon indicating copy to clipboard operation
PathOfBuilding copied to clipboard

Add warnings if skill cost exceeds avilable resource.

Open Paliak opened this issue 3 years ago • 3 comments

Fixes #4998 .

Description of the problem being solved:

Currently there is no warning that a skill uses more life/mana/Es/Rage than is available. This pr also stops auras from not applying their effects even though reservation is applied even when above possible reservation.

Note that this pr makes triggered skills get cached. This may or may not cause issues with some calculations but i was not able to find any issues.

Steps taken to verify a working solution:

  • Check skill setups
  • Check divine blessing interaction
  • Check auras while having two essence worm rings applied the supreme ego allocated.

Before screenshot:

obraz

After screenshot:

obraz

Paliak avatar Sep 02 '22 06:09 Paliak

Text warning for life/energy shield now doesn't seem to appear. Everything else seems fine.

QuickStick123 avatar Sep 18 '22 13:09 QuickStick123

@QuickStick123 I assumed other costs would be in the top level of the cache table too but that was not the case. https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/5019/commits/946c47e48f2a8fcc90a5ff28876ff63246109f9e should fix it. Thanks for the help.

Paliak avatar Sep 18 '22 18:09 Paliak

@QuickStick123 I made it default to 0 if output.Rage is nil so i think it's fine if it stays separate.

Paliak avatar Sep 19 '22 08:09 Paliak

This will need a couple fixes for conflicts generated by https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/5199 being merged

LocalIdentity avatar Dec 08 '22 11:12 LocalIdentity