PathOfBuilding icon indicating copy to clipboard operation
PathOfBuilding copied to clipboard

Add support for Supports via Party tab

Open Regisle opened this issue 3 years ago • 2 comments

This still has a ton of issues so putting it in draft for now The tab has no button atm and must be accessed via hotkey (ctrl 7)

This adds support for auras, aura debuffs and curses, all of which should be fully supported other than condition tags It also adds support for extra auras like tailwind and mana guardian and these seem to work correctly

"function PartyTabClass:ParseTags" needs to be modified to correctly grab tags like conditions etc

So far the only missing one seems to be Slipstream but this could be because its applied by a minion and none of the minion mods are exported

It also adds support for enemy conditions and multipliers are modifiers, these are not handled well atm but will apply Conditions are tagged as "Condition:Party:" instead for later filtering The modifiers added are missing their mod tags (things like conditions etc) and thus always apply

Regisle avatar Aug 22 '22 11:08 Regisle

Putting stuff from discord in here so only things missing are

  1. better handling of conditions etc (handled here https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/4967/files#diff-78d9446a275e2c88641d16d571951f4be470aaee5f297d9b59b92b1d780cae13R371)
  2. better filtering of enemy mods/conditions (handled here https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/4967/files#diff-d06ae38e3b24f60d8d576087b42ecbe64d89bdf119980c7d764549f0c41b5e9cR3262-R3279)

1 and 2 are disabled atm anyway currently it grabs all conditions, multiple of which are always true and some of them are useless

I dont apply the conditions directly atm anyway, I apply them as "Condition:Party:X" so they dont do anything, some of them should probs apply the base version incase the player has some effect that applies eg chill/shock

similarly enemy mods do not check any condition atm, I only save them in the export if their conditions/multipliers are met, but then they get applied regardless

enemy mods should probs check that the negated version is true (eg if wants to know chill then check not chilled, or vice versa) so that the users variant overrides them eg for shock, both the player and the supports shock will apply

but better filtering and better tagging of mods is alot of work and might even have to be done on a case by case basis

Regisle avatar Aug 23 '22 08:08 Regisle

Chiming in as the dev of #2927, one useful feature would be the ability to turn on/off the imported builds. I commonly use the exported 'jewel' method to check carry/culler party stats pre and post buffs.

general handlers look really nice, glad somebody who actually knows Lua is doing this, means I can stop maintaining my hacky version

NathanielHinshaw avatar Sep 03 '22 16:09 NathanielHinshaw

image I get this error when I load a build along with nothing loading. This only occurs on builds saved with this branch.

QuickStick123 avatar Apr 20 '23 02:04 QuickStick123