PathOfBuilding icon indicating copy to clipboard operation
PathOfBuilding copied to clipboard

Indicator of different mastery node options in comparison mode

Open xTeJk opened this issue 3 years ago • 3 comments

At the request of one of the users in the issues section fixes #4957 , I added a indicator about two other options in mastery, from now on different mastery will be dimmed (as in the picture below). In addition corrected the space between the title of the mastery and the main text when comparing (it is 16 everywhere, but for some reason wasn't here) and added a clearer description of the difference in selection (previously "<-" and "->", now separated with line and title that informs about changes.

img

example build to check changes: https://pastebin.com/BYYB2nfn

xTeJk avatar Aug 22 '22 05:08 xTeJk

I think you've misunderstood the request made in #4957 -- they just want differing masteries on the passive tree to be a different colour (no tooltip changes).

edit: clarity

Nightblade avatar Aug 22 '22 06:08 Nightblade

This is more consistent with how we handle similiar things but yes it does miss the point the issue wanted of inicating changes on masteries they want changes to be highlighted orange similar to how we do addition / removals of masteries currently

Mockup How they want modified to be highlighted. image

Current Adding Mastery image

QuickStick123 avatar Dec 08 '22 12:12 QuickStick123

Unfortunately I don't think highlighting any particular color is going to work, since masteries are all colors already. I think the dimmed mastery icon is fine, but I'm less sure about the tooltip change.

Wires77 avatar Dec 10 '22 06:12 Wires77