PathOfBuilding icon indicating copy to clipboard operation
PathOfBuilding copied to clipboard

Display Phantasm DPS in Total DPS

Open APXEOLOG opened this issue 3 years ago • 0 comments

Description of the problem being solved:

Phantasms are not being counted in the Total DPS even if the skill has this support gem inserted

  • Count is based on maximum available phantasm limit
  • DPS is always calculated for the "Physical Projectile" minion's skill
  • Such problem as multiple phantasm sources and global limit is out of scope

Steps taken to verify a working solution:

  1. Create a new skill group
  2. Add some active skill gem
  3. Add Summon Phantasm
  4. Toggle "Show in Total DPS"

Link to a build that showcases this PR:

https://pobb.in/HMjN6iKQ-EDg

Before screenshot:

image

After screenshot:

image

APXEOLOG avatar Jul 28 '22 14:07 APXEOLOG