PathOfBuilding icon indicating copy to clipboard operation
PathOfBuilding copied to clipboard

Fix Absolution spell hit counted multiple times in the Total DPS

Open APXEOLOG opened this issue 3 years ago • 3 comments

Description of the problem being solved:

While calculating Full DPS for Absolution the Count increases not only the number of minions (which is correct) but also multiplies the dps of the spell itself (which is incorrect)

Steps taken to verify a working solution:

  1. Add Absolution active skill
  2. Increase count
  3. Check Include in Full DPS

Link to a build that showcases this PR:

https://pobb.in/-aL0wEIoqGe_

Before screenshot:

image

After screenshot:

image

image

APXEOLOG avatar Jul 27 '22 14:07 APXEOLOG

Is this correct tho? This breaks full dps counter for non-minion absolution (1 example would be spell cascade or totems etc)

deathbeam avatar Jul 27 '22 16:07 deathbeam

Is this correct tho? This breaks full dps counter for non-minion absolution (1 example would be spell cascade or totems etc)

This is a valid concern. In that case, the best approach will be to implement a separate counter for minions. Do you know if there is any flag I can use to differentiate the skills which deal direct damage but still spawn minions from the skills which just spawn minions?

APXEOLOG avatar Jul 27 '22 17:07 APXEOLOG

I've added a config option (disabled by default) to control behavior of the change image

APXEOLOG avatar Jul 28 '22 12:07 APXEOLOG