PathOfBuilding icon indicating copy to clipboard operation
PathOfBuilding copied to clipboard

Fix effect mods that are granted while affected by a buff sometimes not applying.

Open QuickStick123 opened this issue 3 years ago • 0 comments

Fixes #4388.

Sorry for the second pull request I couldn't figure out how to fix the other one.

Description of the problem being solved:

When calculating effect to apply to buffs we add affected by tags at the same time this means if a mod gives effect while under affect it is likely it will be missed.

This was solved by splitting it into two parses first we apply all the tags then we apply the effect and add the buffs.

Steps taken to verify a working solution:

  • Hovering over the total more now correctly shows 36% more spell damage.

Link to a build that showcases this PR:

https://poe.ninja/pob/Bkm

Problematic Mod image

Before screenshot:

image

After screenshot:

image

QuickStick123 avatar Jul 11 '22 07:07 QuickStick123