PathOfBuildingCommunity
Fixed a variety of incorrect catalyst scaling
The current plan with this is to run https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/2662 and then fixed the last few mistakes in here detailed in https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/2662#issuecomment-1179720326.
The changes are based off some testing and work I did in 17/4/2021 So any recently changed mods or new uniques will not be guaranteed to be correct. https://github.com/PathOfBuildingCommunity/PathOfBuilding/issues/2521#issuecomment-821748654 https://docs.google.com/spreadsheets/d/11mOp3VLPXgbhJq562DdFmP34nx4tNqoF47LbrM-R93g/edit#gid=0
Further fixes i did was fixing noxious catalyst to scale physical and chaos damage instead of generic tags.
Fixes #3193 #2843 #2521 #4482
This also provides an alternative fix for #4463
Description of the problem being solved:
Catalyst scaling is incorrect in a number of cases.
Steps taken to verify a working solution:
I have verified all of these either using trade or through in game but I haven't collated documentation due to the large number of changes.
For whoever looks at this, the tags being wrong can be fixed generically with #2662 even if we just run the scripts once to clean everything up. I'm sure there are other uniques with the wrong tags that no one has noticed/reported
I am down to run the script and then just cleanup the remaining few it missed/got wrong. (rare cases of unscalable values) Noxious catalyst still needs to be fixed but that could be split into a separate pull request.