DPS comparison does not apply certain buffs and debuffs to Total Mirage DPS.

[SeventhSolar]

Check version

• [X] I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

• [X] I've checked for duplicate issues by using the search function of the issue tracker

What is the expected behaviour/value?

The comparison preview should report proportional (same percentage) changes in 'Total/DoT DPS' and 'Total Mirage DPS'. In particular, when considering a change that has no effect on dps, the comparison preview shouldn't mention dps changes at all.

What is the actual behaviour/value?

If certain damage buffs or debuffs are applied, comparison previews will calculate the difference between current Mirage DPS numbers as displayed on the left (which properly includes those buffs and debuffs) and its newly calculated Mirage DPS (which does not include aforementioned buffs and debuffs).

Examples of effects that create this behavior: Frenzy charges, Empower support, I don't know if there are any others Examples that do not create this behavior: Malevolence, Despair

I also want to mention Tailwind, which doesn't create issues overall, but its effect specifically doesn't show up in the comparison when allocating or deallocating Gathering Winds. Same goes for the Corruption passive.

How to reproduce the issue

1. Equip a bow.
2. Slot Toxic Rain supported by Mirage Archer.
3. Click on the minor passive directly before Disciple of the Slaughter.
4. Spec and unspec Disciple of the Slaughter to compare DPS comparison with actual effect on DPS numbers on left.
5. Hover an unrelated passive to see unexpected effect on Mirage DPS.
6. Slot Empower with Toxic Rain and Mirage Archer to see the same effect.

Build code

https://pastebin.com/9B366mi7

Screenshots

[SeventhSolar]

I'm utterly confused. Frenzy charges still causes the issue, but I can no longer duplicate the comparison effect with Corruption. Now it only causes the tooltip to be incorrect specifically when equipping and removing the Corruption-anointed amulet, similar to Tailwind. I should have taken a screenshot so I could be confident about whether or not I even reported it correctly.

[SeventhSolar]

Identified Empower Support as another culprit.

[NelsonMinar]

I think I'm seeing this bug too. My build is at https://pastebin.com/NWsr3zDQ

If I try to add 12% Projectile Damage the tooltip shows my Mirage Archer DPS going down 20%. That makes no sense! But if I click the node to add it the Main Skill damage panel instead shows that DPS going up a little, like I'd expect. I think it's a bug specific to the tooltip calculation.

The bug also appears when looking at the tooltip for nodes that have nothing to do with DPS, like Ghost Dance.

FWIW my setup is pretty different from the original bug reporter. I don't have Empower or Corruption. I see the bug whether I have "Frenzy charges" clicked in the Configuration or not, but the magnitude of the effect is much bigger with Frenzy (20% vs 6%).

I'm a software engineer and glad to help do more detailed testing if needed.

[0x66656c6978]

I'm able to reproduce this without any configuration, with just importing my character: Mirage Archer Tooltip DPS calculation is wrong, even when hovering nodes that have nothing to do with DPS. Exactly what @NelsonMinar said.

https://pastebin.com/qANGny7M

Is anyone looking into this?

[QuickStick123]

The code has a lot of problem related to mirage archers (see the mirage archer project). No one is currently investigating / looking into fixing this feel free to yourself if you have the time. If you need help fixing it feel free to message one of our maintainers on discord to join and ask questions.