SocialRepo icon indicating copy to clipboard operation
SocialRepo copied to clipboard

[FEATURE] Add Links on Save in Home Panel

Open Param302 opened this issue 1 year ago • 4 comments

Add Links on Save in Home Panel

Overview

You have to implement add social link box functionality for Home panel which should create social link box whenever Save button is called.

image image

Requirements

  • After adding some links in Edit panel, whenever user clicks Save button, it should create link containers of those links in Home panel.
  • It should only create link containers of those links which are completed.
    • A link is completed, when there's no bottom line present below the link in Edit panel.
    • 2nd link shown in first image is completed link, others are invalid/incompleted links.
    • You can use isValidURL() function from index.js to check whether a link is valid or not.
    • Or you can check for CSS styling too, both should work.
  • It should create social link box same as provided in 2nd image.
  • For creating the social link box in home panel, you can use createSocialLink(key, value) function from index.js, where key can be retrieve from socialLinks object and value should be same as the provided link in input element of link-box in Edit panel.
  • Must follow the Code Guidelines provided.
  • To test the code, setup the extension by following these steps.
  • All the functionality should be implemented in index.js only.

If you have any suggestion or idea, you're welcome to share.

Let's implement SocialRepo's save button functionality! 🙌

Param302 avatar May 26 '24 21:05 Param302

Hey @Param302, I would like to work on this issue. please assign this to me.

CodexRaunak avatar Jun 11 '24 12:06 CodexRaunak

Hey @Param302, I would like to work on this issue. please assign this to me.

Sure @CodexRaunak !

Assigning you the issue.

Param302 avatar Jun 11 '24 12:06 Param302

Hey @Param302 I want to ask when the user adds a valid URL in the edit section, then the link box will be created in the Home Panel. But if he adds the same URL again within the edit box, then what will happen? I have made the functionality till he adds and it gets saved in the home panel, but if he adds it again, then one more list box is created with the same key and value.

Please clarify what is the ideal scenario, is it like user will edit the link and it will get added to the home panel, if there is already a same list box existing then it will not create a new box but update the previous one.

Below is the image of the added code, please do let me know if there is any issue.

addLink Box

CodexRaunak avatar Jun 13 '24 09:06 CodexRaunak

oh oky, @CodexRaunak so it's a bug :sweat_smile: , we actually want all the links to be unique. Right now, don't worry about it, as creating the home links will depends upon creating link in edit container, I will fix it.

Thanks for pointing out this bug!

Param302 avatar Jun 13 '24 19:06 Param302