Waterfall icon indicating copy to clipboard operation
Waterfall copied to clipboard

If a player has a potion effect,he will be kicked from server

Open ksgfk opened this issue 6 years ago • 6 comments

MC:1.12.2 Forge:14.23.5.2838 SpongeForge:1.12.2-2825-7.1.6

As long as the player gets the potion effect, he will be kicked out.

Waterfull show that bad packet ID, are mods in use!? Did not read all bytes from packet class net.md_5.bungee.protocol.packet.EntityEffect 79 Protocol GAME Direction TO_CLIENT

There are many potion effects in mods which I install in my server.Will this have any impact?

ksgfk avatar Aug 17 '19 03:08 ksgfk

You have a mod which is modifying the contents of the potions packet, waterfall cares about this in order to fix a race condition with forge, which makes this a fun one to solve; Would really need to know what these mods are doing to the packet in order to determine a proper fix

electronicboy avatar Aug 17 '19 03:08 electronicboy

I think I found it.If I install Just Enought IDs,it will happen.After that,I remove that,waterfull work properly.

ksgfk avatar Aug 17 '19 03:08 ksgfk

You have a mod which is modifying the contents of the potions packet, waterfall cares about this in order to fix a race condition with forge, which makes this a fun one to solve; Would really need to know what these mods are doing to the packet in order to determine a proper fix

I have the same problem and same error logs with slashblade and tinkersconstruct slashblade : when the player is using a sa, he's kicked out tinkersconstruct:when the player triggers some special effects of certain materials like cobalt,hes kicked out

what waterfall shows :<-> DownstreamBridge <-> [lobby] - bad packet ID, are mods in use!? Did not read all bytes from packet class net.md_5.bungee.protocol.packet.EntityEffect 79 Protocol GAME Direction TO_CLIENT

after removing JEIDS on BOTH clinet and server,the problem disappears

alex450 avatar Aug 17 '19 12:08 alex450

@electronicboy Would you merge a fix for this that deactivates rewriting for these scenarios? (With or without config option, that's your call)

Xernium avatar Jun 10 '20 10:06 Xernium

I'm more wondering what these mods are doing, and what versions this is actually applicable to, as I have a feeling it would be viable to just say to skip rewriting on those versions, and maybe look at handling the extra data and just throw it though

On Wed, 10 Jun 2020, 11:37 FivePB (Xer), [email protected] wrote:

@electronicboy https://github.com/electronicboy Would you merge a fix for this that deactivates rewriting for these scenarios? (With or without config option, that's your call)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PaperMC/Waterfall/issues/418#issuecomment-641915484, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJMAZEEVU4FWSD535DLD4LRV5O5NANCNFSM4IMOBX5A .

electronicboy avatar Jun 10 '20 10:06 electronicboy