feat(plugin): auto updates
closes #809
TODO:
- [x] Rollback in case of a failure while updating
- [x] Let the users enable/disable auto updates using config or startup flags
- [x] Test changes
This would be a great feature :)
Is there any progress here?
The Merge conflicts can be resolved easily, i rebased the branch and fixed the checkstyles in this branch: https://github.com/Joo200/Velocity/tree/feat/update-plugins
Not too sure how I did not get a notification for pending conflicts in this pull request and how I passed the check-style last time
Hiiii, Has any reviewer had a chance to look at the official code yet? It's been nearly a year in the making, but it's better late than never
I'm using this on my server and it works fine. The implementation and the code looks fine.
I'm not a reviewer here so I can't hit the approve button in github. But imo it should be ready to be merged.
I'm gonna do it: @4drian3d @StealWonders can we get a review ππΎππΎ
Erm Any update?
Kind of conflicted on the usage of List instead of HashMap for loaded candidates. Using HashMap would help in matching of plugin ids when trying to search for the possible updates here
PluginDescription possibleMatch = found.get(updatedDescription.getId());
Do we wanna use streams here or should we revert back to HashMap
You have conflicts to resolve before requesting another review