Velocity icon indicating copy to clipboard operation
Velocity copied to clipboard

feat(plugin): auto updates

Open AV3RG opened this issue 3 years ago β€’ 14 comments

closes #809

TODO:

  • [x] Rollback in case of a failure while updating
  • [x] Let the users enable/disable auto updates using config or startup flags
  • [x] Test changes

AV3RG avatar Aug 16 '22 09:08 AV3RG

This would be a great feature :)

Noorquacker avatar Dec 16 '22 03:12 Noorquacker

Is there any progress here?

The Merge conflicts can be resolved easily, i rebased the branch and fixed the checkstyles in this branch: https://github.com/Joo200/Velocity/tree/feat/update-plugins

Joo200 avatar Mar 26 '23 07:03 Joo200

Not too sure how I did not get a notification for pending conflicts in this pull request and how I passed the check-style last time

AV3RG avatar Mar 28 '23 16:03 AV3RG

Hiiii, Has any reviewer had a chance to look at the official code yet? It's been nearly a year in the making, but it's better late than never

Noorquacker avatar Jul 10 '23 23:07 Noorquacker

I'm using this on my server and it works fine. The implementation and the code looks fine.

I'm not a reviewer here so I can't hit the approve button in github. But imo it should be ready to be merged.

Joo200 avatar Jul 12 '23 19:07 Joo200

I'm gonna do it: @4drian3d @StealWonders can we get a review πŸ‘‰πŸΎπŸ‘ˆπŸΎ

Noorquacker avatar Jul 13 '23 02:07 Noorquacker

Erm Any update?

Noorquacker avatar Dec 05 '23 18:12 Noorquacker

Kind of conflicted on the usage of List instead of HashMap for loaded candidates. Using HashMap would help in matching of plugin ids when trying to search for the possible updates here PluginDescription possibleMatch = found.get(updatedDescription.getId());

Do we wanna use streams here or should we revert back to HashMap

AV3RG avatar Dec 16 '23 07:12 AV3RG

You have conflicts to resolve before requesting another review image

4drian3d avatar Feb 25 '24 18:02 4drian3d