Paper icon indicating copy to clipboard operation
Paper copied to clipboard
verified publisher icon PaperMC

ratelimited packet is logged to console on kick

Open bdotsamir opened this issue 2 years ago • 6 comments

First PR 🎉 Huge thanks to lynxplay for helping me out here

Hopefully fixes issue: #8747

bdotsamir avatar Jun 09 '23 17:06 bdotsamir

I WAS HERE xqcL I WAS HERE xqcL I WAS HERE xqcL I WAS HERE xqcL I WAS HERE xqcL I WAS HERE xqcL I WAS HERE xqcL I WAS HERE xqcL

EternalHuman avatar Jun 09 '23 17:06 EternalHuman

Welcome to paper :tada: thank you for your first PR.

Things we should discuss here are

  • [ ] Should this be behind a configuration option ?
  • [ ] This should probably also explicitly mention the user kicked

lynxplay avatar Jun 09 '23 17:06 lynxplay

I don't think this needs to be behind a config option as it is, arguably, very useful information. But yeah, the user / UUID in suspect should be logged IMO

olijeffers0n avatar Jun 09 '23 17:06 olijeffers0n

I don‘t see any case this is not needed. In every case i have in my mind, it would be thankful to have the reason and the user logged.

cosmohdx avatar Jun 09 '23 18:06 cosmohdx

depends on how easy it is to trip, flooding logs is one of the many fun DDoS style attacks you can do, especially for servers running in janky wrapper processes; this is probably not a concern here, but it's not like log messages are 100% free

electronicboy avatar Jun 09 '23 18:06 electronicboy

This should be under a configuration option considering what electronicboy said

MachineBreaker avatar Jun 09 '23 20:06 MachineBreaker