Paper icon indicating copy to clipboard operation
Paper copied to clipboard

Use a proper thread pool in ServerLoginPacketListenerImpl and MCUtil

Open egg82 opened this issue 3 years ago • 1 comments

Fixes #8797

An arbitrary-ish number of 1024 was chosen for the bounded queue size. The asyncExecutor in MCUtil was left unbounded.

egg82 avatar Jan 18 '23 19:01 egg82

  1. You mangled the formatting
  2. core size of 16 is excessive, especially as the thread pool will race towards that needlessly; I'd probably just go for like 4 or something, and maybe make it configurable; ofc, this is actually probably a pretty good target for green threads in the future

electronicboy avatar Jan 18 '23 21:01 electronicboy

Are you still planning on moving forward with this ? I don't recall the dhrama discussion about it but I'd close this otherwise.

lynxplay avatar Mar 11 '23 17:03 lynxplay

Closing this given it has gone rather stale :sweat: (love you egg <3)

lynxplay avatar Aug 06 '23 02:08 lynxplay