Paper icon indicating copy to clipboard operation
Paper copied to clipboard

Unsuccessful authorization (SimpleVoiceChat)

Open zentixua opened this issue 3 years ago • 4 comments

Expected behavior

When joining the server, if the port that the simple voice uses is open, the simple voice will connect to the client in 100% of cases (if mod installed)

Observed/Actual behavior

When you use paper, voice chat will ALMOST (occasionally, randomly) not work:

  • From time to time (as if randomly) when joining the server, the plugin will not be able to authorize the player. According to my observation, this most often happens at the first login to the server.
  • If you do the steps below.

Steps/models to reproduce

This plugin will not be able to authorize the player (and voice chat will almost not work) if you do the following:

  1. Create a new paper server.
  2. Install simple voice
  3. Log in to the server
  4. Fly around the world (away from spawn) for about a minute
  5. Get down, break some blocks
  6. Log out of the server
  7. Stop it right away
  8. Start again
  9. Log in 5-6 seconds after server start
  10. You will see the problem.

Plugin and Datapack List

Datapacks: 0 Plugins (1): voicechat (simple voice)

Paper version

paper 1.19.2-307

Other

  • During the investigation, I and the simple voice support (henkelmax) came to the conclusion that the problem only occurs on paper and its forks (everything is fine on spigot)
  • I was asked to create this issue in SimpleVoice support, administrators will discuss it here (more technical information will be provided)
  • https://discord.com/channels/854659575324344340/1047604717569712248 - here you can see the progress of our investigation with henkelmax (discord server: https://discord.gg/UUPn3Hr9Eb)
  • https://github.com/henkelmax/simple-voice-chat/issues/508 - old investigation, but it was not quite correct
  • on 1.19.3 the same problem

zentixua avatar Dec 14 '22 13:12 zentixua

I can confirm this issue.

If you follow these steps

Create a new paper server. Install simple voice Log in to the server Fly around the world (away from spawn) for about a minute Get down, break some blocks Log out of the server Stop it right away Start again Log in 5-6 seconds after server start You will see the problem.

Paper will not send plugin messages (player.sendPluginMessage) to clients. I double checked and everything works fine with Bukkit and Spigot (Latest versions for 1.19.2).

henkelmax avatar Dec 14 '22 14:12 henkelmax

Paper will not send plugin messages (player.sendPluginMessage) to clients.

Are you ensuring that you correctly registered the player as a recipient for that plugin message channel? Would you be able to perhaps log which packets are sent spigot vs paper and see if there is some difference with the plugin messages here?

Owen1212055 avatar Dec 23 '22 20:12 Owen1212055

image Seeing as though you did this, are you able to check is the sendPluginMessage being executed BEFORE the client sends a packet to register the pluginmessage channel?

Owen1212055 avatar Dec 23 '22 20:12 Owen1212055

image Seeing as though you did this, are you able to check is the sendPluginMessage being executed BEFORE the client sends a packet to register the pluginmessage channel?

The plugin message channel is registered at server start. I'm sending the plugin message after a player joined. In these test cases, I am joining about 10 seconds after the server fully booted, so that can't be the issue.

henkelmax avatar Dec 24 '22 08:12 henkelmax