PaperMC
Fix placeable/destory keys deserialization from spigot
Somethings else to consider regarding the representation of those tags in Bukkit: Minecraft stores these tags in a list (duplicates are not filtered, order is preserved), whereas this CraftMetaItem implementation seems to put them into an unordered HashSet. So a back and forth conversion from Minecraft -> Bukkit -> Minecraft might result in those tags being reordered, potentially affecting the comparisons of Minecraft items. Maybe it makes sense to store these tags in a List in Bukkit as well. Or at least store them in a LinkedHashSet. Or enforce a particular order, similar to how enchantments are reordered in Paper.
Somethings else to consider regarding the representation of those tags in Bukkit: Minecraft stores these tags in a list (duplicates are not filtered, order is preserved), whereas this CraftMetaItem implementation seems to put them into an unordered HashSet. So a back and forth conversion from Minecraft -> Bukkit -> Minecraft might result in those tags being reordered, potentially affecting the comparisons of Minecraft items. Maybe it makes sense to store these tags in a List in Bukkit as well. Or at least store them in a LinkedHashSet. Or enforce a particular order, similar to how enchantments are reordered in Paper.
Yeah, I just handled that by changing the fields on CraftMetaItem to lists, but the API still returns a set.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue has been automatically closed because it has not had activity in a long time. If the issue still applies to the most recent supported version, please open a new issue referencing this original issue.