Paper icon indicating copy to clipboard operation
Paper copied to clipboard

Port mspt command to brigadier

Open NonSwag opened this issue 7 months ago • 6 comments

image

I only deprecated the old MSPT command since I thought there might be plugins out there that access the eval or getColor methods or check for the class name existence or other ~~intelligent~~ stuff

NonSwag avatar Jun 05 '25 12:06 NonSwag

I wonder, couldn't we actually just fallback to spark's /spark tps command? That one displays far more useful information, which makes the classic Bukkit-style /tps command basically obsolete. Or is there actually a good use case for the Bukkit one?

EDIT: I re-read what this actually changes. This is for MSPT, mb lol. But my point basically still stands as long as we are touching these statistic-style commands

Strokkur424 avatar Jun 05 '25 12:06 Strokkur424

I totally agree but iirc there was a reason for the TPS command not being replaced with the spark TPS command, but that's better off being answered by a staff member.

NonSwag avatar Jun 05 '25 13:06 NonSwag

image

The information conveyed by the spark TPS command is not only more detailed but also much more readable, so I would be in favor of replacing TPS and MSPT completely.

NonSwag avatar Jun 05 '25 13:06 NonSwag

I don't feel there's any need to keep the old MSPT command... its not in the API at all.

Machine-Maker avatar Jun 06 '25 23:06 Machine-Maker

replacing the output of the tps command was a concern due to various things reading the output of that, I've long also generally considered tps to be a useless metric and would defer to the mspt values instead; For as worthless as the tps is, it made little sense to care about randomly changing the format of the command and dealing with the consequences of that

electronicboy avatar Jun 06 '25 23:06 electronicboy

I also agree that we should prolly just remove the command class.

Owen1212055 avatar Jun 21 '25 06:06 Owen1212055