update paper 1.20.6

[ColdeZhang]

Try to update for 1.20.6.

Known problems:

• [x] kyori:adventure versions doesnt match, and 4.17.0 is not available;
• [x] ChunkStatus.java class missing;
• [x] Some more typing error happened by migration;

[MiniDigger]

https://github.com/KyoriPowered/adventure/releases/tag/v4.17.0 was just released

[Luuzzi]

btw

remapper - net.fabricmc:tiny-remapper:0.10.1:fat -> net.fabricmc:tiny-remapper:0.10.2:fat decompiler - net.minecraftforge:forgeflower:2.0.627.2 -> org.vineflower:vineflower:1.10.1

I think the changes are minor, but it still seems necessary

[ColdeZhang]

https://github.com/KyoriPowered/adventure/releases/tag/v4.17.0 was just released

I found it. But upstream paper using 4.17.0-snapshot in api, and 4.16.0 in server. I noticed in server build script have a commnet saying "Keep in sync with adventureVersion from Paper-API build file".

So I'm not sure if it should be modified in folia patch, I think maybe its belonging to paper's patch?

[Leguan16]

Are you sure? It has been updated an hour ago or so.

[ColdeZhang]

btw

remapper - net.fabricmc:tiny-remapper:0.10.1:fat -> net.fabricmc:tiny-remapper:0.10.2:fat decompiler - net.minecraftforge:forgeflower:2.0.627.2 -> org.vineflower:vineflower:1.10.1

I think the changes are minor, but it still seems necessary

Yes, UR right. It vital for some class to be decompiled.

[ColdeZhang]

https://github.com/KyoriPowered/adventure/releases/tag/v4.17.0 was just released

I found it. But upstream paper using 4.17.0-snapshot in api, and 4.16.0 in server. I noticed in server build script have a commnet saying "Keep in sync with adventureVersion from Paper-API build file".

So I'm not sure if it should be modified in folia patch, I think maybe its belonging to paper's patch?

This has been fixed by Paper

[ColdeZhang]

Migrations from folia's patch are done, there still a syntax err in net/minecraft/core/dispenser/ProjectileDispenseBehavior.java line 48 DispenserBlock.eventFired should use get() to fetch bollen type. I leave it alone, because it doesnt changed in folias patch, I think it's upstream's work.

Anyway, patches can be compiled allreday.

[ColdeZhang]

Greetings, maintainers. I'm done with 1.20.6 update. Could you review it please?

[ColdeZhang]

Fine, I got new problem.

Any commands send by client will cause "Internal Exception: java.lang.UnsupportedOperationException", and then kicked. Commands send my console is ok.

This fault has no stacktrace, just "Internal Exception", I dont know how to debug it.

[electronicboy]

enable debug in server.properties or attach a profiler which can do exception recording

but, large PRs should generally be cleared by leaf first, not sure how much acceptance there is towards pulling in an update from somebody else

[Luuzzi]

enable debug in server.properties or attach a profiler which can do exception recording

but, large PRs should generally be cleared by leaf first, not sure how much acceptance there is towards pulling in an update from somebody else

Is he on vacation now? There is no information when we will be able to get a review of this PR or update to 1.20.6?

[PedroMPagani]

Fine, I got new problem.

Any commands send by client will cause "Internal Exception: java.lang.UnsupportedOperationException", and then kicked. Commands send my console is ok.

This fault has no stacktrace, just "Internal Exception", I dont know how to debug it.

You can attach exception catchers on the netty threads, that'll be usually it unless you're testing with plugins iirc you're not it seems, I'll get on development in your branch too, to help test out and get it ready.

[ColdeZhang]

Fine, I got new problem. Any commands send by client will cause "Internal Exception: java.lang.UnsupportedOperationException", and then kicked. Commands send my console is ok. This fault has no stacktrace, just "Internal Exception", I dont know how to debug it.

You can attach exception catchers on the netty threads, that'll be usually it unless you're testing with plugins iirc you're not it seems, I'll get on development in your branch too, to help test out and get it ready.

enable debug in server.properties or attach a profiler which can do exception recording

but, large PRs should generally be cleared by leaf first, not sure how much acceptance there is towards pulling in an update from somebody else

Thanks for your guide, I have solved it. Look like works fine :)

[PedroMPagani]

Are you missing something on ProjectileDispenseBehavior? it doesn't build, it's missing .get()

[ColdeZhang]

Are you missing something on ProjectileDispenseBehavior? it doesn't build, it's missing .get()

Yes I leave it alone, because I thought that's upstream's work. It doesnt caused by folia patch, so I keep it out of folia's patch.

For now I change it manually each time before I build.

Do you guys think it should be in folia's patch? If so, I may add it.

[PedroMPagani]

Yes, that's a folia change, it should be changed, on paper that's a boolean, on folia for thread safety that's a thread local. IT should be on the patch

[ColdeZhang]

Yes, that's a folia change, it should be changed, on paper that's a boolean, on folia for thread safety that's a thread local. IT should be on the patch

Ok , got it. I may have a missing.

[ColdeZhang]

Things should be looks better now.

[PedroMPagani]

this all lgtm, seems to be working already tested the majority of the features, including experimental.

[Spottedleaf]

In general we (Paper included) don't take external work for updates, since there's a lot of things involved that can go wrong

https://github.com/PaperMC/Folia/tree/dev/1.20.6