QuCumber icon indicating copy to clipboard operation
QuCumber copied to clipboard

[WIP] Transition to PyTorch's complex API

Open emerali opened this issue 5 years ago • 0 comments

This won't be merged for a while since PyTorch's complex API isn't stable yet

TODO:

  • [ ] Fix KL bug
    • KL divergence seems like it's being computed wrong for the complex cases (DensityMatrix's numerical and algorithmic gradients seem to both be wrong)
    • [ ] Add gradient tests which only operate in the reference basis (i.e. dont need to do any grad rotations)
    • [x] In gradient tests, if the gradients for one sub-network are wrong, the other sub-networks aren't tested. Should fix this to test all sub-networks before erroring out (maybe separate tests for each sub-network?)

emerali avatar Sep 08 '20 17:09 emerali