GoogleAuthenticator icon indicating copy to clipboard operation
GoogleAuthenticator copied to clipboard
verified publisher icon PHPGangsta

Shouldn't we write a recommended version of PHP?

Open fumiya5863 opened this issue 5 years ago • 2 comments

The PHP formula says random_bytes is greater than or equal to 7.0

Note: Although this function was added to PHP in PHP 7.0

Wouldn't it be better to write that 7.0 or higher is recommended for README?

fumiya5863 avatar Jan 03 '21 13:01 fumiya5863

The code is written with a number of fallbacks. It uses random_bytes() if it is available, but has a number of other alternatives if not. Therefore, the module currently works on a large number of PHP versions, at least as far back as PHP 5.3, if not further (whilst also working on the latest PHP releases).

It might still be worth explicitly stating the versions of PHP that are supported, though.

MarkMaldaba avatar Mar 12 '21 13:03 MarkMaldaba

Thank you for your comment. Certainly, I think it would be good for future users to list the PHP version in the README.

fumiya5863 avatar Mar 15 '21 01:03 fumiya5863