PEtab icon indicating copy to clipboard operation
PEtab copied to clipboard

v2: Add log10-uniform distribution to support conversion from v1

Open dilpath opened this issue 9 months ago • 1 comments

Which problem would you like to address? Please describe. v1 problems support parameterScale=log10. There is no way to convert this into a v2 problem currently. parameterScale=log is not an issue because v2 will support log-uniform priors. The tool can optionally use the log-uniform prior as a hint to optimize on log scale with a uniform prior, which matches v1 behavior.

Describe the solution you would like There is already another log10-prior in v2 (log10-normal). Add the log10-uniform prior.

dilpath avatar Apr 25 '25 10:04 dilpath

There is no way to convert this into a v2 problem currently.

The same applies to laplace / log10-laplace.

I guess, if we add the log10 distributions for parameters, we can allow them for observable.noiseDistribution as well to support all previously available observableTransformations (some were removed in https://github.com/PEtab-dev/PEtab/pull/619).

dweindl avatar Apr 25 '25 10:04 dweindl

From the last PEtab editor meeting: It would be preferable if we could avoid adding any of these.

It feels like we should also remove the log10-normal prior then to make things more consistent.

dweindl avatar May 21 '25 13:05 dweindl