docker-compose icon indicating copy to clipboard operation
docker-compose copied to clipboard

PR: Streaming api

Open frank-dspeed opened this issue 6 years ago • 3 comments

This PR Implaments Streaming API and class API

const cwd = process.cwd()
const dockerCompose = require('docker-compose/class') 
const compose = new dockerCompose({ cwd })
compose.upAll()
compose.upAllStream()
compose.logsStream()

Will Write more soon and Push my Integration for this module

frank-dspeed avatar Jun 14 '19 06:06 frank-dspeed

https://github.com/direktspeed/docker-compose "master"

frank-dspeed avatar Jun 14 '19 07:06 frank-dspeed

It's not a PR though :)

At this point it doesn't seem to differ too much. Looking forward to it.

Just a note: since we're still "supporting" NodeJS 6 (which didn't have class support afair) we will need to have compilation process ready to downgrade the code. Also, I'm not 100% exactly sold on using a class, but it's more an opinion than anything.

Steveb-p avatar Jun 14 '19 07:06 Steveb-p

@frank-dspeed Thanks for your work. As @Steveb-p said, it's not a PR - if you need help here, just let us know.

@Steveb-p Node.js 6 did support ES6 class. As Node 6 is EOL I'm considering to no longer support it anyway.

AlexZeitler avatar Jun 14 '19 09:06 AlexZeitler