pcgen icon indicating copy to clipboard operation
pcgen copied to clipboard

[BUG] Langauge choice window modal and unclosable

Open jfalconnet opened this issue 4 years ago • 3 comments

Describe the bug The window to select language is stick. When I click Cancel or Ok nothing happends, and I cant do anything else I have to kill the app.

To Reproduce Steps to reproduce the behavior:

  1. Lauch PCGEN (6.09.05)
  2. Click on Sources > Load Sources SRD 3.5 for Players
  3. Click on New
  4. Set Intelligence to 12
  5. On the left of summary page, click the "Add Bonus Language"
  6. Click ok. (or cancel)
  7. The Add Bonus Language does not close, and nothing respond anymore.

The behavior is the same if we have chosen a Race before (and thus have chosen a possible language) The behavior is the same through Add Language via Skill point The behavior is the same through "Feats & Abilities" > Misc > GM Awards > Add Language : but only if we choose "cancel" (with other sources that allow this GM awards)

Expected behavior The window should close and we should be able to go on.

Screenshots PcgenLangBug

Desktop (please complete the following information):

  • OS: Ubuntu
  • Version: 20.04.2 LTS

Additional context For the "Feats & Abilities" > Misc > GM Awards > Add Language" way, there is a misspell : the window title is "Langauge choice" instead of "Language choice".

jfalconnet avatar Jun 05 '21 10:06 jfalconnet

Reproducible in 6.09.05, Ubuntu 20.04, openjdk-11. I should let you know though that 6.09.05 does have quite a few issues with stuff like pop-up windows hanging indefinitely, due to undergoing work to transition the UI from Java Swing to JavaFX. Development is slow across the board in PCGen, so if you like, 6.08.00RC8 is also supported and doesn't have a lot of these issues.

pokemonpasta avatar Jun 05 '21 10:06 pokemonpasta

Not reproduced on master. In my screen I see this: image

but am able to hit "okay" or "close"

if instead I choose "add language via skill points" I do see this: image

but am able to close/cancel/X

perhaps we just need a release?

grimreaper avatar Sep 23 '21 00:09 grimreaper

The referenced bug was a partial fix

grimreaper avatar Sep 23 '21 19:09 grimreaper