facets icon indicating copy to clipboard operation
facets copied to clipboard

Facets overview rendering strangeness in Edge browser.

Open minimaxir opened this issue 8 years ago • 10 comments

From loading the Quick, Draw demo in macOS 12.10.5 / Safari 10.1.1. (also occurs on Safari iOS).

minimaxir avatar Jul 18 '17 00:07 minimaxir

Thanks for bringing this to our attention. We were able to reproduce that the demos don't work in Safari. For now, you can workaround by viewing them in Chrome. Will fix for Safari ASAP.

bengiswex avatar Jul 18 '17 01:07 bengiswex

It seems I have the same problem with Firefox 54.0 & Ubuntu 16.04. The Jupyter Overview_demo renders no output as well.

valentas-kurauskas avatar Jul 18 '17 14:07 valentas-kurauskas

Cannot view demo in Microsoft Edge (Windows 10), either.

Object doesn't support property or method 'getStatsProto' facets (286,5)

image

mg1075 avatar Jul 18 '17 19:07 mg1075

@mg1075 @valentas-kurauskas @minimaxir please try the demo pages again on your non-chrome browsers.

I updated the gh-pages branch demo code that drives the demo pages (see commit https://github.com/PAIR-code/facets/commit/c4364836b9d44f1c3d16f227cd827db68d6c2b9b). The code now loads the webcomponents-lite polyfill (to support browsers that don't have the webcomponents standard built-in) and only loads the facets code once the polyfill is loaded.

It will still be the case that using the visualizations in jupyter will only currently work in Chrome, but the demo pages should be cross-browser compatible now.

jameswex avatar Jul 19 '17 15:07 jameswex

@jameswex - Microsoft Edge, Windows 10: the visualizations do show up now.

I see odd behavior with the "log | expand | percentages" menu. First it shows at top. The "Chart to show" option is not visible. Then if I click a checkbox, the section moves to its normal spot, and the "Chart to show" option becomes visible.

image

image

Here's a view from the console.

image

mg1075 avatar Jul 19 '17 15:07 mg1075

Changed the title of this issue as the initial issue is solved and now the remaining issue is an issue with some of the control positions in the Edge browser.

jameswex avatar Jul 24 '17 23:07 jameswex

@jameswex Firefox 57, Debian Linux:

The demo page works for me (https://pair-code.github.io/facets/) but the jupyter notebook integration doesn't display at all for me.

jeremysalwen avatar Apr 24 '18 18:04 jeremysalwen

@jeremysalwen do you have errors in your developers console (assuming you are in chrome?)? Most likely the facets-dist jupyter extension wasn't installed in the place that the code in that notebook is expecting.

jameswex avatar Apr 24 '18 18:04 jameswex

@jameswex I am on Firefox 57, I will check for console errors tomorrow.

jeremysalwen avatar Apr 26 '18 04:04 jeremysalwen

The only issue I could see are the downloading of the of fonts, but the page looks fine on Firefox 99.0.1 (64-bit) Windows

image

avilella avatar May 03 '22 09:05 avilella