biobankAccelerometerAnalysis icon indicating copy to clipboard operation
biobankAccelerometerAnalysis copied to clipboard
verified publisher icon OxWearables

Added support for Windows

Open cosmicnet opened this issue 4 years ago • 1 comments

Hi,

The following has been tested on Windows 10 with conda 4.10.1

cosmicnet avatar May 06 '21 19:05 cosmicnet

Thanks for the PR @cosmicnet . After a quick glance, changes in this PR is grossly similar to the changes that I made in the DREAMS trial for windows support with better documentation. Likely to work.

Guess @chanshing @R-Walmsley would be the best people to review this since you have direct access to windows machines?

angerhang avatar May 06 '21 21:05 angerhang

@cosmicnet Hi Lyle, do we need to updated the README in this PR? Package is in PyPI now so we now install using pip install accelerometer.

chanshing avatar Sep 07 '22 07:09 chanshing

Yeah, a lot has changed since I did this. I can update it to work with the new code. I think all that is needed in the readme now would be a note to say that the windows support is experimental. Unless you have other ideas?

cosmicnet avatar Sep 07 '22 07:09 cosmicnet

Fixed in 68257a7dd18ea3030cd25085df84ef940279e862 Thanks @cosmicnet !

chanshing avatar Sep 22 '22 12:09 chanshing

Thanks for fixing this!

cosmicnet avatar Oct 18 '22 10:10 cosmicnet