VulkanTutorial icon indicating copy to clipboard operation
VulkanTutorial copied to clipboard

The Chinese translation is complete. Request a review.

Open huzhenbang opened this issue 3 years ago • 14 comments

The Chinese translation is complete. Request a review.

huzhenbang avatar Oct 09 '22 13:10 huzhenbang

Any native speakers who can pitch in to review this? @chirsz-ever @fangcun010

Overv avatar Nov 03 '22 22:11 Overv

翻译应该放在 zh 文件夹并中并在 config.json 中加入中文配置,参见 https://github.com/chirsz-ever/VulkanTutorial/commit/6802acba9711c2a574d66c6966e43436956c8c9f

chirsz-ever avatar Nov 05 '22 10:11 chirsz-ever

build_ebook.py 换行符变成了 CRLF,应该维持原样使用 LF。

如果是在 Windows 上进行开发可以将 git 配置为提交时使用 LF,checkout 到文件系统中时使用 CRLF^git-autocrlf

git config --global core.autocrlf true

配置后建议使用 git add --renormalize . 清理工作区。

chirsz-ever avatar Nov 05 '22 10:11 chirsz-ever

~~duax.io 处理中文 URL 有问题,文件名应当改用英文,并在文件开头使用元数据块来指明中文标题~~

中文路径问题将在 https://github.com/Overv/daux.io/pull/2 被合入后解决。

chirsz-ever avatar Nov 05 '22 11:11 chirsz-ever

发现的一些问题:

  • 不少地方原文用行内代码块(`xxx`)的翻译过来后改成双引号了;
  • 半角和全角标点混用以及错用,有时导致 Markdown 语法错误; https://github.com/Overv/VulkanTutorial/blob/41a2a9b1b6e246ccfe7983f6db11fec398cdadcb/ch/95_%E9%9A%90%E7%A7%81%E6%94%BF%E7%AD%96.md#L21
  • 没有注意汉字与英文单词、行内代码块之间的空格; https://github.com/Overv/VulkanTutorial/blob/41a2a9b1b6e246ccfe7983f6db11fec398cdadcb/ch/03_%E7%BB%98%E5%88%B6%E4%B8%89%E8%A7%92%E5%BD%A2/00_%E8%AE%BE%E7%BD%AE/03_%E7%89%A9%E7%90%86%E8%AE%BE%E5%A4%87%E4%B8%8E%E9%98%9F%E5%88%97%E6%97%8F.md#L21
  • Mipmap 应翻译为“多级渐远纹理”

排版相关可以参考 中文排版指北

图形学术语可以参考《游戏引擎架构》中英词汇索引表

参考 这里 的建议,某些术语可以保留英文原文,如使用“uniform buffer”或“uniform 缓冲”而非“统一缓冲区”,“统一的缓冲区”。

chirsz-ever avatar Nov 05 '22 19:11 chirsz-ever

When will the translation be deployed? @Overv

orbitgw avatar Apr 19 '23 17:04 orbitgw

@orbitgw Would you be willing to go through the chapters and review them? If a native speaker can confirm that it looks good then this can be deployed.

Overv avatar Apr 19 '23 21:04 Overv

@Overv I would be happy to do it, but it will take time. Cause I am currently a high school student and am about to face the college entrance examination. I need to put more energy into my studies. I will graduate in June 2024, and by then, I will have plenty of time to do this work.

orbitgw avatar Apr 20 '23 16:04 orbitgw

@orbitgw That is fine. Perhaps someone else has a chance to look at it earlier.

Overv avatar Apr 20 '23 16:04 Overv

This PR is a mess with unrelatied modifications and wrong format. The author did not take action or reply to comments for half a year. I think I could start a new translation PR in some days.

@Overv How do you think about https://github.com/Overv/daux.io/pull/2? If you think it change too much, It's OK to just add https://github.com/Overv/daux.io/commit/b3ab5c3a79e0e69a4685e79c6da14d5bc2ac0399 to remove hard-coded "Introduction" path, and I will use English file names in the Chinese translation.

chirsz-ever avatar Apr 20 '23 17:04 chirsz-ever

@chirsz-ever

This PR is a mess with unrelatied modifications and wrong format. The author did not take action or reply to comments for half a year. I think I could start a new translation PR in some days.

@Overv How do you think about Overv/daux.io#2? If you think it change too much, It's OK to just add Overv/daux.io@b3ab5c3 to remove hard-coded "Introduction" path, and I will use English file names in the Chinese translation.

我赞同你的想法,用中文做路径太奇怪了,而且不好访问

orbitgw avatar Apr 21 '23 17:04 orbitgw

@Overv I have roughly browsed through it and there is a suspicion that this PR may have completely used translation software without manual verification.

orbitgw avatar Apr 21 '23 17:04 orbitgw

@chirsz-ever 我想咱们可以合作一下

orbitgw avatar Apr 21 '23 17:04 orbitgw

我同意,用英文保留文件名会更方便,这样它们就更容易与其他版本匹配了

翻译准备好发布时,我会修复介绍路径

Overv avatar Apr 24 '23 19:04 Overv