jKey icon indicating copy to clipboard operation
jKey copied to clipboard

Unbinding jKey events

Open vala opened this issue 14 years ago • 4 comments

Hi there,

I'd just wanted to point out that there's no explanation on how to unbind a jKey event, although I found it easily looking at your code, it may be something good to just write it somewhere in the README file or maybe making a more "clean" way to do it. For now I made it this way

$(element).unbind('keydown.jkey');

For me it's all right, but it implies that I unbind every key event associated to element If you're ok with patches I'd be pleased to write one in order to implement some way to make it possible to unbind specifical key events, in order to do something like that :

$(element).jkey('unbind', 'left, right');

Thanks for the plug, works really well!

Cheers

vala avatar Aug 31 '11 16:08 vala

That would rock! There was a guy a few months back who tried to patch it also but no avail on his end. If you could do this that'd be great. It's for sure the number 1 thing missing right now from jKey.

OscarGodson avatar Aug 31 '11 16:08 OscarGodson

Fine, I'll be on it. I'll fork your repo this night and be patching it !

vala avatar Aug 31 '11 17:08 vala

Hooray! We'll all be cheering you on ;)

hooray

OscarGodson avatar Aug 31 '11 21:08 OscarGodson

Heh thanks for the pic, I really feel supported ! I don't got enough time today to finiss it but I got my solution, It may be quite an overkill but tomorrow I'll be pushing it so you can review it and maybe find where it can be optimized, it'll make me change a bit the way callbacks are called but I think it will be ok. I'll keep you up

vala avatar Aug 31 '11 22:08 vala