CONQUEST-release icon indicating copy to clipboard operation
CONQUEST-release copied to clipboard

Remove pointers in multiply module

Open tkoskela opened this issue 2 years ago • 2 comments

This PR removes pointers to part_array in multiply_module and passes slices of part_array to subroutines instead. It also tries to clarify the indexing of part_array to make it clearer which slice is being passed.

I'm open to opinions on whether or not this is a good idea. It's more of a style change than anything else, although it should make the code more robust against the kind of memory errors in #280. I would argue this is a more Fortran style use of arrays, compared to the C-style use of pointers. It does make the subroutine calls somewhat longer

tkoskela avatar Nov 30 '23 13:11 tkoskela

Actually, can this PR please wait until we merge #290 @tkoskela ? The conflicts will be a much bigger pain if we do it the other way round....

ilectra avatar Dec 20 '23 17:12 ilectra

I want to think about this change some more, and discuss it with @tsuyoshi38 before we approve it

davidbowler avatar Dec 21 '23 09:12 davidbowler