CONQUEST-release icon indicating copy to clipboard operation
CONQUEST-release copied to clipboard

Overlap communication with computation in multiply_module

Open ilectra opened this issue 2 years ago • 3 comments

Fixes #265

ilectra avatar Nov 27 '23 18:11 ilectra

From @davidbowler: compute is only being called on kpart [2 : end]. To fix, call compute kernels on kpart -1 then call once after the loop on kpart.

tkoskela avatar Dec 05 '23 10:12 tkoskela

I think this can be reviewed now. I'll produce some profiles, to see if we gained anything, when I'm back from the holidays, I don't think I'll have time tomorrow.

ilectra avatar Dec 20 '23 17:12 ilectra

There's no performance improvement seen, if anything there's a small degradation (see below). I think I understand why: the problem is the order communications are received, and not the time they take. Screenshot from 2024-06-17 12-44-45 Will not merge for now, and instead investigate optimising the order in https://github.com/OrderN/CONQUEST-release/tree/ic-mm-comms-optimise-order . If that works, then we can revisit overlapping comms with computation, for further improvement.

ilectra avatar Jun 17 '24 11:06 ilectra