Orange-Boosted-Bootstrap icon indicating copy to clipboard operation
Orange-Boosted-Bootstrap copied to clipboard

Cards : fix design + add design callout messages

Open isabellechanclou opened this issue 2 years ago • 2 comments

Related issues

Closes #1992 Linked to #1199

Description

After a design review of all the card variants, the purpose of this PR is to fix the design of some variants in order to make them aligned on the Orange design specifications and to add design callout messages before the variants that should not be used because not suitable in Orange design system.

Motivation & Context

The goal here is to offer in Boosted more guidance on what can be used or not in Orange apps and to reduce discrepancies between Boosted documentation and the Orange design system one.

Types of change

  • [x] Bug fix (non-breaking which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Live previews

Checklist

Contribution

Accessibility

  • [x] My change follows accessibility good practices; I have at least run axe

Design

  • [x] My change respects the design guidelines defined in Orange Design System
  • [x] My change is compatible with responsive display

Development

  • [x] My change follows the developer guide
  • [ ] I have added JavaScript unit tests to cover my changes
  • [ ] I have added SCSS unit tests to cover my changes

Documentation

  • [x] My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • [ ] My change introduces changes to the migration guide
  • [ ] My new component is added in Storybook
  • [ ] My new component is compatible with RTL
  • [ ] Manually run BrowserStack tests
  • [ ] Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • [x] Code review
  • [x] Design review
  • [ ] A11y review

After the merge

isabellechanclou avatar Apr 18 '23 14:04 isabellechanclou

Deploy Preview for boosted ready!

Name Link
Latest commit 9e033e964619ff92eaaefd0b92f40822fa2a6331
Latest deploy log https://app.netlify.com/sites/boosted/deploys/659bd290a92e2f00089a5862
Deploy Preview https://deploy-preview-2001--boosted.netlify.app/docs/5.3/components/card
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 18 '23 15:04 netlify[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar May 12 '23 13:05 sonarqubecloud[bot]

Thanks a lot for this work. It has been gathered and merged with other modifications in https://github.com/Orange-OpenSource/Orange-Boosted-Bootstrap/pull/2625. All participants of this PR will be mentioned as co-authors in it.

julien-deramond avatar Jul 18 '24 05:07 julien-deramond