IOT-Map-Component icon indicating copy to clipboard operation
IOT-Map-Component copied to clipboard

Popup: Fix z-index in any case

Open louismaximepiton opened this issue 2 years ago • 1 comments

Description

There are two solutions to answer the #34 issue:

  1. The first one is to remove https://github.com/Orange-OpenSource/IOT-Map-Component/blob/a2d92f15415944a00fc850e90cb018a209be3d5d/src/iotMapManager/src/iot-map-marker.ts#L53 This way seems more logical, but the following could happen: image

  2. The second one is to increase the zindexOffset of the same line to 1000000 as what was done inside the PR to avoid the case illustrated above. This looks to be mandatory because of this line on Markercluster side: https://github.com/Leaflet/Leaflet.markercluster/blob/bd2794c35831612a86f63766c26d94f809de7abc/src/MarkerCluster.Spiderfier.js#L237

Maybe we can handle this in a different way but this seemed the more logical to me right now

How to test

Change id: 's2' to get the following:

location: {
  lat: 44.892,
  lng: 4.872
},

Related issues

Fixes #34.

louismaximepiton avatar Feb 21 '24 09:02 louismaximepiton

Deploy Preview for iotmapcomponent ready!

Name Link
Latest commit be40072164108343dedef8f60a0ad4c2ddd149c0
Latest deploy log https://app.netlify.com/sites/iotmapcomponent/deploys/65dc9a8666fd6700080b0f79
Deploy Preview https://deploy-preview-161--iotmapcomponent.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Feb 26 '24 14:02 netlify[bot]