IOT-Map-Component icon indicating copy to clipboard operation
IOT-Map-Component copied to clipboard

Fix some controls' rendering in Storybook

Open julien-deramond opened this issue 2 years ago • 0 comments

Description

https://github.com/Orange-OpenSource/IOT-Map-Component/pull/151 was a complex PR that was getting rid of addon-knobs. In the process of doing that, something was not handled completely.

As you can see in https://orange-opensource.github.io/IOT-Map-Component/?path=/story/gauge--gauge&args=shapePercent:33, when you modify the value of shape.percent in the "Controls" tab, the value is taken into account in the view but the value doesn't change in the "Controls" view; it stays to 15/100.

In this same view, the boolean default value is not set in the "Controls" view. However, the color and number inputs work correctly.

In https://orange-opensource.github.io/IOT-Map-Component/?path=/story/gaugewithinner--gauge-with-inner, the text input in the "Controls" view doesn't change even if the value is well-changed on the map rendering side.

Same thing in https://orange-opensource.github.io/IOT-Map-Component/?path=/story/shapes--shapes where the default radio buttons values are not set.

There's an undefined issue globally in the way the "Controls" panel view is updated/synchronized.

julien-deramond avatar Feb 15 '24 11:02 julien-deramond