resources_api icon indicating copy to clipboard operation
resources_api copied to clipboard

Add uid and gid as Docker environment variables

Open platipo opened this issue 5 years ago • 8 comments

Reference: https://github.com/OperationCode/resources_api/pull/388#issuecomment-706335715

platipo avatar Oct 11 '20 18:10 platipo

Hi @aaron-suarez, I added the dotenv orb an it seems working. Do you have any feedback?

Maybe using a variable for the group id is an overkill, what do you think?

platipo avatar Oct 11 '20 18:10 platipo

Why is it 1000 sometimes and 5000 other times? Its not a problem I just don't understand what difference it makes

aaron-junot avatar Oct 12 '20 14:10 aaron-junot

I wasn't sure if all was correct so I chose to set the environment default values to a different number if it had raised an error I would have confirmed that the variables weren't propagating correctly.

platipo avatar Oct 12 '20 16:10 platipo

I can just set them all to 5000 if you want. Also do you want me to keep also the gid?

platipo avatar Oct 12 '20 16:10 platipo

It's fine how it is if you just want to leave it. If you feel like removing the gid, you can as long as it still works

aaron-junot avatar Oct 12 '20 17:10 aaron-junot

I'm ok with all the changes, do you prefer that Dockerfile default variables are 5000?

platipo avatar Oct 12 '20 17:10 platipo

It's fine how it is. I'm mobile right now but when I get the chance to run it and make sure everything works, I'll approve and merge if nothing is broken. Thanks for this!

aaron-junot avatar Oct 12 '20 19:10 aaron-junot

Hi @aaron-suarez, did you manage to try the changes?

platipo avatar Oct 14 '20 13:10 platipo