resources_api icon indicating copy to clipboard operation
resources_api copied to clipboard

Fix remaining issues with tests

Open aaron-junot opened this issue 6 years ago • 3 comments

In #266 we made a lot of improvement on the tests, but we had to throw in the towel on a few of the issues:

  1. The search tests might not be testing anything. See https://github.com/OperationCode/resources_api/pull/266#discussion_r361545451

  2. There's almost certainly a better abstraction for test_algolia_exception_error and test_algolia_unreachable_host_error because they are the exact same test, just with different fake errors returned from algolia. Someone can go in and abstract out the similarities and perhaps inject the mocks just where they're needed to cut down on the code and/or execution time. See https://github.com/OperationCode/resources_api/pull/266#discussion_r363545482

  3. We were never able to implement test_false_validation due to problems mocking the correct function. I'm not sure if it was our implementation or perhaps a bug in pytest-mock, but it just wasn't working for us. If you can make it work, we'd love this test to exist. See https://github.com/OperationCode/resources_api/pull/266#discussion_r363123518

aaron-junot avatar Jan 10 '20 02:01 aaron-junot

@rooshs481 is going to take this one on

aaron-junot avatar Jun 04 '20 19:06 aaron-junot

I think nobody is currently working on this. @aaron-suarez Can I work on this?

fumblehool avatar Oct 20 '20 18:10 fumblehool

Go ahead @fumblehool !

aaron-junot avatar Oct 20 '20 22:10 aaron-junot