openzeppelin-contracts icon indicating copy to clipboard operation
openzeppelin-contracts copied to clipboard
verified publisher icon OpenZeppelin

Update Arbitrum's vendored contracts to Nitro

Open Amxx opened this issue 3 years ago • 1 comments

Vendor contract from arbitrum nitro

Some types have been changed (for example from IOwnable to address. The change are marked by // OZ: retyped from xxx

PR Checklist

  • [x] Tests
  • [ ] Documentation
  • [x] Changelog entry

Amxx avatar Sep 08 '22 18:09 Amxx

Thanks @Amxx for submitting this. :purple_heart:

istankovic avatar Sep 09 '22 07:09 istankovic

Some types have been changed (for example from IOwnable to address. The change are marked by // OZ: retyped from xxx

Do we need these annotations for some technical reason? I would prefer to remove them.

Is this PR ready to be moved out of Draft?

frangio avatar Sep 27 '22 17:09 frangio

Some types have been changed (for example from IOwnable to address. The change are marked by // OZ: retyped from xxx

Do we need these annotations for some technical reason? I would prefer to remove them.

It did not feel right to vendor a modified version of Arbitrum's code without documenting the changes.

Amxx avatar Sep 27 '22 19:09 Amxx