cairo-contracts icon indicating copy to clipboard operation
cairo-contracts copied to clipboard
verified publisher icon OpenZeppelin

Add ERC6909

Open swan-of-bodom opened this issue 1 year ago • 3 comments

Adding the new multi-token standard ERC6909 written in Cairo. This token standard will most likely be used by UniswapV4 so might be interesting to have one for Cairo too as discussed with @andrew-fleming

  • [x] Tests
  • [x] Documentation
  • [x] Added entry to CHANGELOG.md
  • [x] Tried the feature on a public network

Deploy transaction: 0x004297aadb57195520d58b6de3db91c14bb30284080c78b7f3d65407d2d06e79

Mint transaction: 0x008debb59434cc64f432110c118d8ba64725545764a71529c7226d127d46df5a

Thanks!

swan-of-bodom avatar Jul 08 '24 20:07 swan-of-bodom

Thanks for opening this PR @swan-of-bodom! It may take some time to review this since it's quite big, but we'll get to it as soon as we can

andrew-fleming avatar Jul 09 '24 17:07 andrew-fleming

Thanks for opening this PR @swan-of-bodom! It may take some time to review this since it's quite big, but we'll get to it as soon as we can

No worries, thank you!

swan-of-bodom avatar Jul 09 '24 20:07 swan-of-bodom

Thanks for your efforts! I've left several suggestions. Please note that to approve the implementation we'll have to wait till the EIP-6909 is finalized, since atm it's still in the draft state

Thanks, happy to contribute to this great library :)

swan-of-bodom avatar Aug 13 '24 11:08 swan-of-bodom

Hi! This feature would be super helpful. The PR is stale and shows merge conflicts. I’m happy to revive it by rebasing on main, resolving conflicts, adding tests/docs, and opening a fresh PR that preserves authorship and references this one. Unless anyone objects, I’ll proceed in ~1 week and mark the new PR as “Supersedes #1040”, keeping @swan-of-bodom as co-author. Thanks!

0xpantera avatar Oct 28 '25 14:10 0xpantera

Hey @swan-of-bodom, thanks for taking the time to work on this!

Since this PR has been inactive for a while and the codebase has moved forward significantly, we're going to take this over internally to get it across the finish line. We really appreciate the effort you put in, and we'll likely keep some of your commits as part of the final implementation.

Thanks again for your contribution!

bidzyyys avatar Nov 13 '25 12:11 bidzyyys

Hi @bidzyyys, I was making some progress on moving @swan-of-bodom PR forward recently. You may want to check it out here.

Happy to help work this in.

lumoswiz avatar Nov 13 '25 13:11 lumoswiz