OpenWaterAnalytics
Reporting Tank Status
PR #505 has added a Tank Overflow feature to the EPANET engine that might require some updating of the way that a tank's change in status is described in the Status report. Currently we use FILLING, EMPTYING and CLOSED (without stating whether the tank is full or empty). I propose we change these to FILLING, EMPTYING, OVERFLOWING, OFFLINE, OFFLINE-FULL, and OFFLINE-EMPTY.
In addition, we could add a new tank property, EN_TANKSTATUS, that could be retrieved using the EN_getnodevalue() API function. It would have the same values as listed above. I realize that these states could always be checked for in code by using EN_getnodevalue() on EN_TANKLEVEL and EN_DEMAND, but EN_TANKSTATUS would make the job easier.
I totally agree.
@LRossman can you just explain what you mean by the OFFLINE cases? It is when the tank is closed?
I suggested that OFFLINE be used to describe a condition where the tank is neither filling nor emptying (i.e., when its EN_DEMAND value is 0). It might not be the best choice of words, since it implies that the tank has been disconnected from the network which is not the case (e.g., an example of a truly offline tank is one that is undergoing a cleaning or other maintenance). Perhaps LEVEL is a better choice, or we could stay with CLOSED.
In the interest of avoiding further delay in finishing release 2.2, PR #505 was updated to have the Status Report state when a tank begins overflowing (in addition to its current practice of reporting when a tank begins filling, emptying or is closed). The more detailed reporting of a tank's status as discussed in this issue can be a future enhancement.
Resolved in the sense that it remains a feature to consider adding in a future version of the Toolkit.