SVT-VP9 icon indicating copy to clipboard operation
SVT-VP9 copied to clipboard

Segmentation Fault when number of processors > 16

Open keks51 opened this issue 1 year ago • 5 comments

In some cases like virtualization one processor has exactly one core. But there is s strict number of MAX_PROCESSOR_GROUP which is 16. https://github.com/OpenVisualCloud/SVT-VP9/blob/master/Source/Lib/Codec/EbEncHandle.c#L137

The suggestion is to increase this value to 1024.

Also it is better to replace this line https://github.com/OpenVisualCloud/SVT-VP9/blob/master/Source/Lib/Codec/EbEncHandle.c#L406 with

if (socket_id < 0 || socket_id > MAX_PROCESSOR_GROUP - 1) {

keks51 avatar Mar 17 '25 10:03 keks51

Do you also have this issue with SVT-AV1?

1480c1 avatar Mar 17 '25 18:03 1480c1

Do you also have this issue with SVT-AV1?

No. Everything is fine

keks51 avatar Mar 18 '25 09:03 keks51

I see, the reason why I asked was I believe SVT-AV1 and SVT-VP9 have similar code regarding this, so if it's broken in one, it might be broken in the other, and it would be best to collaborate and fix both at the same time.

1480c1 avatar Mar 18 '25 16:03 1480c1

I see, the reason why I asked was I believe SVT-AV1 and SVT-VP9 have similar code regarding this, so if it's broken in one, it might be broken in the other, and it would be best to collaborate and fix both at the same time.

Hi. I also ran into the same issue with SVT-HEVC. Seems like i will have this issue with SVT-AV1. I just haven't started using it yet in prod cluster.

keks51 avatar May 07 '25 14:05 keks51

@keks51 Considering the amount of threads involved, are you perhaps able to reproduce #174?

davidebeatrici avatar May 14 '25 05:05 davidebeatrici