OpenVic icon indicating copy to clipboard operation
OpenVic copied to clipboard

Province names do not convert non-ascii characters to Unicode

Open Spartan322 opened this issue 2 years ago • 2 comments

For example: busted unicode openvic

Spartan322 avatar Dec 25 '23 21:12 Spartan322

Appears fine on Windows, produces garbage display on Linux. Need confirmation on Mac.

Spartan322 avatar Dec 26 '23 19:12 Spartan322

Appears to function fine on Mac, this appears to be dependent on the system. Still Unicode characters should be converted from Windows-1252 characters.

Spartan322 avatar Dec 27 '23 01:12 Spartan322

While Godot 4.2.2 seems to somehow solved this issue for Windows-1252 on every platform by presuming invalid Unicode single byte characters are Windows-1252, it does not fix it for Windows-1251 which would otherwise contradict that presumption. Since as well it is safer to deal with Unicode characters, OpenVicProject/OpenVic-Dataloader#46 will force total compliance with Unicode eliminating the potential for this issue from appearing with Windows-1251 or reappearing from Windows-1252 in the future.

Spartan322 avatar Jun 14 '24 04:06 Spartan322

Issue fixed for the simulation but remains until we use String::utf8 for our string conversions from the simulation to godot. Also pertains potentially to any non-ascii characters in the data files, not just the localization files. (I don't believe this matters much aside from debugging)

Spartan322 avatar Jul 31 '24 21:07 Spartan322