openvpnserv2 icon indicating copy to clipboard operation
openvpnserv2 copied to clipboard

Moving to interactive service

Open lstipakov opened this issue 10 months ago • 5 comments

lstipakov avatar Mar 10 '25 10:03 lstipakov

Its a bit hard to review this with all the refactoring going on. Would it be possible to split this with the refactoring and cleanup moved to a future PR? I thought the last commit would pretty much covers all that is needed for the iservice-based startup to work.

But my idea was exactly this - there are few commits for refactoring without any functional changes (like splitting functionality into different files) and this last commit is switching to iservice.

lstipakov avatar Mar 12 '25 07:03 lstipakov

Here you can get an installer with necessary changes to all components. At least here it works fine :)

lstipakov avatar Mar 13 '25 13:03 lstipakov

I think this service should start the interactive service, if it is not running already.

d12fk avatar Mar 13 '25 22:03 d12fk

I think this service should start the interactive service, if it is not running already.

It is now depends on interactive service https://github.com/OpenVPN/openvpn-build/pull/849/files so Windows should start iservice first.

lstipakov avatar Mar 14 '25 06:03 lstipakov

Ping @selvanair @d12fk

lstipakov avatar Mar 31 '25 14:03 lstipakov

Doxygen would be nice, but a bit more excessive commit messages, describing the things done in the commit, are missing often.

d12fk avatar Apr 10 '25 02:04 d12fk

Doxygen would be nice, but a bit more excessive commit messages, describing the things done in the commit, are missing often.

Made some commit messages more descriptive and added some XML comments - this is a standard way to document code in C# and is natively supported by Visual Studio (unlike Doxygen). Also, Doxygen is able to parse them.

lstipakov avatar Apr 14 '25 08:04 lstipakov